Fix Display of Selected Option Label in Radio Button Select Lists with Collections #427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… by using Object.assign instead of this.$set
danloa
approved these changes
Jul 4, 2024
|
0.0% Coverage on New Code
0.0% Duplication on New Code
|
Closing. Fix by #428 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves an issue where select lists configured as radio buttons with collections did not display the selected option label. The problem was identified through a failing E2E test.
Issue:
The issue was due to the overwriting of a particular property
__content__withinthis.selectedListOptionswhen an option was selected.Solution:
Updated the method to use
Object.assigninstead ofthis.$setto ensure existing properties are not overwritten.How to Test
Related Tickets and PRs
FOUR-16938
ci:next