Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FOUR-19561:In a screen with more than one page, when I zoom more than 150% I return to the first page #1782

Open
wants to merge 2 commits into
base: release-2024-fall
Choose a base branch
from

Conversation

fagubla
Copy link
Contributor

@fagubla fagubla commented Jan 2, 2025

Issue & Reproduction Steps

  1. Create a process: Start Event - Task - End Event.
  2. In the Task, create a screen with 2 pages. Page 1 has a Page Navigation button to take the user to the second page.
  3. Save the screen and publish the process.
  4. Start a case.
  5. Click on the Navigation Button.
  6. On the second page, zoom to 150%.

Current Behavior:
The screen returns to the first page.

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

ci:deploy

Copy link

cypress bot commented Jan 2, 2025

screen-builder    Run #1704

Run Properties:  status check failed Failed #1704  •  git commit ca44e5549b: FOUR-19561:In a screen with more than one page, when I zoom more than 150% I ret...
Project screen-builder
Branch Review bugfix/FOUR-19561
Run status status check failed Failed #1704
Run duration 09m 10s
Commit git commit ca44e5549b: FOUR-19561:In a screen with more than one page, when I zoom more than 150% I ret...
Committer Fabio Rodolfo Guachalla Blanco
View all properties for this run ↗︎

Test results
Tests that failed  Failures 1
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 19
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 365
View all changes introduced in this branch ↗︎

Tests for review

Failed  tests/e2e/specs/ComputedFields.spec.js • 1 failed test • CI - Chrome

View Output

Test Artifacts
Computed fields > Focuses the first field that has an error Test Replay Screenshots

@fagubla
Copy link
Contributor Author

fagubla commented Jan 3, 2025

@caleeli all tests are green

@caleeli caleeli self-requested a review January 7, 2025 19:04
Copy link
Contributor

@caleeli caleeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants