Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FOUR-20206: Update the Copy Control icon as figma #1779

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

rodriquelca
Copy link
Contributor

@rodriquelca rodriquelca commented Nov 15, 2024

Issue & Reproduction Steps

Expected behavior:
The Copy control Icon of controls actually is gray, it should be blue as figma design.
Actual behavior:
The Copy control Icon of controls actually is gray

Solution

  • Update the Copy button to use the primary button class instead of the secondary button class.
image

How to Test

Test the steps above

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

Copy link

cypress bot commented Nov 15, 2024

screen-builder    Run #1691

Run Properties:  status check passed Passed #1691  •  git commit b67681fa89: FOUR-20206: Update the Copy Control icon as figma
Project screen-builder
Branch Review bugfix/FOUR-20206
Run status status check passed Passed #1691
Run duration 08m 54s
Commit git commit b67681fa89: FOUR-20206: Update the Copy Control icon as figma
Committer rodrigo
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 19
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 365
View all changes introduced in this branch ↗︎

@rodriquelca rodriquelca requested a review from caleeli November 15, 2024 13:49
@ryancooley ryancooley merged commit 29bfc4a into release-2024-fall Nov 20, 2024
24 of 28 checks passed
@ryancooley ryancooley deleted the bugfix/FOUR-20206 branch November 20, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants