Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FOUR-20051: Error in console when entering the LDAP configuration page #1777

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

danloa
Copy link
Contributor

@danloa danloa commented Nov 14, 2024

Issue & Reproduction Steps

  • Log in
  • Go to admin
  • Click on Log in Auth
  • Click on LDAP

Current Behavior:
When entering the LDAP configuration page, we get an error message in the console.

Solution

Added Optional Chaining operator to get the _parent from data.

How to Test

Test the steps above

Related Tickets & Packages

https://processmaker.atlassian.net/browse/FOUR-20051

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

ci:release-2024-fall

Copy link

cypress bot commented Nov 14, 2024

screen-builder    Run #1689

Run Properties:  status check passed Passed #1689  •  git commit 5a0424e616: FOUR-20051: Error in console when entering the LDAP configuration page
Project screen-builder
Branch Review bugfix/FOUR-20051
Run status status check passed Passed #1689
Run duration 42m 17s
Commit git commit 5a0424e616: FOUR-20051: Error in console when entering the LDAP configuration page
Committer danloa
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 19
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 365
View all changes introduced in this branch ↗︎

@ryancooley ryancooley merged commit a3a0285 into release-2024-fall Nov 20, 2024
16 checks passed
@ryancooley ryancooley deleted the bugfix/FOUR-20051 branch November 20, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants