Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FOUR-19011: Case completed message is not displayed #1767

Merged
merged 4 commits into from
Oct 30, 2024

Conversation

rodriquelca
Copy link
Contributor

Issue & Reproduction Steps

Expected behavior:
The message "This request is complete" should appear when completing the request
Actual behavior:
The user is redirected to summary

Solution

  • add a isWebEntry property to identify if the task is running in web entry mode
web_entry_redirect.mov

How to Test

Test the steps above

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

Copy link

cypress bot commented Oct 29, 2024

screen-builder    Run #1653

Run Properties:  status check passed Passed #1653  •  git commit 584cd743b6: FOUR-19011: Case completed message is not displayed
Project screen-builder
Branch Review bugfix/FOUR-19011
Run status status check passed Passed #1653
Run duration 41m 24s
Commit git commit 584cd743b6: FOUR-19011: Case completed message is not displayed
Committer rodrigo
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 19
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 359
View all changes introduced in this branch ↗︎

@caleeli caleeli self-requested a review October 30, 2024 14:48
@ryancooley ryancooley merged commit 3fc4e53 into release-2024-fall Oct 30, 2024
16 checks passed
@ryancooley ryancooley deleted the bugfix/FOUR-19011 branch October 30, 2024 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants