Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FOUR-19877 | Truncate Template Name on Screen Template Cards #1766

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

mcraeteisha
Copy link
Contributor

@mcraeteisha mcraeteisha commented Oct 29, 2024

Issue

Ticket: FOUR-19877
While there is a character limit on Template names on Screen Template Cards (in the Screen Templates Panel), the name should also be truncated when displayed in the card to prevent size differences between cards. The template description has also been shortened on the template card, so that only two lines of the description are displayed.

Solution

  • Truncate template name via truncateText method.
  • Truncate template description more, so that only two lines of text show, similar to the Figma mockups.

Previous UI

Screen Shot 2024-10-29 at 11 30 43 AM

Updated UI

Screen Shot 2024-10-29 at 11 42 23 AM

How to Test

  1. Go to branch observation/FOUR-19877 in screen-builder.
  2. Go to Designer → Screens.
  3. Create a Screen Template that has a long Title and Description.
  4. Open a Screen to edit. Select 'Templates' from the top menu bar.
  5. When the template card displays:
    • The title should appear truncated so that approximately two lines of text display
    • The description should appear truncated so that approximately two lines of text display.

Related Ticket

FOUR-19828

ci:deploy

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

Copy link

cypress bot commented Oct 29, 2024

screen-builder    Run #1637

Run Properties:  status check passed Passed #1637  •  git commit 77e498dd5e: FOUR-19877 | Truncate Template Name on Screen Template Cards
Project screen-builder
Branch Review observation/FOUR-19877
Run status status check passed Passed #1637
Run duration 08m 44s
Commit git commit 77e498dd5e: FOUR-19877 | Truncate Template Name on Screen Template Cards
Committer Teisha McRae
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 19
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 342
View all changes introduced in this branch ↗︎

@tokensPM
Copy link

QA server K8S was successfully deployed https://ci-5cd9c321cd.engk8s.processmaker.net

@ryancooley ryancooley merged commit 35572fb into release-2024-fall Oct 29, 2024
23 of 28 checks passed
@ryancooley ryancooley deleted the observation/FOUR-19877 branch October 29, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants