Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FOUR-19778 Encrypted field does not have read-only mode #1765

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

julceslauhub
Copy link
Contributor

Issue & Reproduction Steps

Expected behavior:
"readonly" attribute should be considered when a value is revealed/plain

Actual behavior:
"readonly" attribute is omitted

Solution

Keep a copy of the original values in order to restore the correct "readonly" mode

Related Tickets & Packages

https://processmaker.atlassian.net/browse/FOUR-19778

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

@julceslauhub julceslauhub requested a review from caleeli October 28, 2024 20:46
Copy link

cypress bot commented Oct 28, 2024

screen-builder    Run #1635

Run Properties:  status check passed Passed #1635  •  git commit 4661f6ebcc: FOUR-19778 Encrypted field does not have read-only mode
Project screen-builder
Branch Review FOUR-19778
Run status status check passed Passed #1635
Run duration 08m 48s
Commit git commit 4661f6ebcc: FOUR-19778 Encrypted field does not have read-only mode
Committer julceslauhub
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 19
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 343
View all changes introduced in this branch ↗︎

Copy link
Contributor

@caleeli caleeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@julceslauhub please include the test for the Encrypted Field + Read-only scenario

@ryancooley ryancooley merged commit fd14fa4 into release-2024-fall Oct 29, 2024
15 checks passed
@ryancooley ryancooley deleted the FOUR-19778 branch October 29, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants