Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/FOUR-19277: Collection Record control displays different errors when mustache variable is assigned in the record ID field #1753

Merged
merged 5 commits into from
Oct 25, 2024

Conversation

CarliPinell
Copy link
Contributor

Solution

  • Record ID field support mustache syntax

How to Test

  • Login PM4
  • Go to Designer->screens
  • Select an existing screen or create one in mode FORM
  • Drag Collection Record Control
  • Select a Collection
  • In Record ID field enter {{ id_record }}
  • Drag an input field and rename as id_record
  • Go to Preview Button, and type some Number in the input field
  • The Collections fields must be shown

Related Tickets & Packages

https://processmaker.atlassian.net/browse/FOUR-19277

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

Copy link

cypress bot commented Oct 23, 2024

screen-builder    Run #1594

Run Properties:  status check passed Passed #1594  •  git commit 995aa91a63: Bugfix/FOUR-19277: Collection Record control displays different errors when must...
Project screen-builder
Branch Review bugfix/FOUR-19277
Run status status check passed Passed #1594
Run duration 08m 36s
Commit git commit 995aa91a63: Bugfix/FOUR-19277: Collection Record control displays different errors when must...
Committer CarliPinell
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 19
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 341
View all changes introduced in this branch ↗︎

@ryancooley ryancooley merged commit 0613365 into release-2024-fall Oct 25, 2024
15 checks passed
@ryancooley ryancooley deleted the bugfix/FOUR-19277 branch October 25, 2024 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants