FOUR-19662: Enforce Height Limit on Thumbnail and Character Limit on Description in Template Card #1752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implemented method to truncate template description to 100 characters. - Added ellipsis (…) for longer descriptions.
- Updated CSS to handle vertical images by using object-fit: cover. - Ensured all images are displayed properly in 107px height container without distortion (according to Figma mockups).
9 tasks
eiresendez
changed the title
screen-builder
|
||||||||||||||||||||||||||||
| Project |
screen-builder
|
| Branch Review |
observation/FOUR-19662
|
| Run status |
|
| Run duration | 08m 46s |
| Commit |
|
| Committer | Eleazar Resendez |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
19
|
Skipped
|
0
|
Passing
|
341
|
| View all changes introduced in this branch ↗︎ | |
|
It seems that there's a flaky test, as the phpunit error is not related to PR's changes. Case Controller (Tests\Feature\Api\V1_1\CaseController) |
sanjacornelius
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue & Reproduction Steps
There is no enforced height limit on the thumbnail or character limit on the description for templates, resulting in inconsistent display and layout issues within the template card. Per the PRD the description should have a 100 character limit
Solution
How to Test
Related Tickets & Packages