Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FOUR-19630 Fix Support backward compatibility of screens #1747

Merged
merged 11 commits into from
Oct 22, 2024

Conversation

caleeli
Copy link
Contributor

@caleeli caleeli commented Oct 21, 2024

Issue & Reproduction Steps

  • When importing a screen from a previous version, fields inside multi columns could not be added to the clipboard

Solution

  • Fix the migration code to add the missing UUID to the multi-column elements

How to Test

  • Import the attached screen
  • Try to add each control to the clipboard

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

Copy link

cypress bot commented Oct 21, 2024

screen-builder    Run #1577

Run Properties:  status check passed Passed #1577  •  git commit b906026ee1: FOUR-19630 Fix Support backward compatibility of screens
Project screen-builder
Branch Review FOUR-19630
Run status status check passed Passed #1577
Run duration 35m 56s
Commit git commit b906026ee1: FOUR-19630 Fix Support backward compatibility of screens
Committer David Callizaya
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 19
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 336
View all changes introduced in this branch ↗︎

@ryancooley ryancooley merged commit 5c4bf33 into release-2024-fall Oct 22, 2024
16 checks passed
@ryancooley ryancooley deleted the FOUR-19630 branch October 22, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants