Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UI Styling for Single and Multiple File Uploads in Conversational Forms #1746

Merged
merged 5 commits into from
Oct 21, 2024

Conversation

sanjacornelius
Copy link
Contributor

@sanjacornelius sanjacornelius commented Oct 18, 2024

This PR resolves UI styling issues for both single and multiple file uploads in the File Upload control of conversational forms. The problem stemmed from inconsistent styling between single and multiple uploads, and incorrect handling of background and layout when files were uploaded or deleted.

Changes:

  • Unified the implementation of the has-uploaded-files class to handle the styling for both single and multiple file uploads, ensuring consistent background color and preventing overlap with the chat history content.
  • Added logic to emit and handle file deletion events, ensuring that when a file is deleted, the UI correctly updates to remove the uploaded file styling and reverts to its original state.

How to Test:

Single File Upload:

  1. Create a conversational form using a File Upload control.
  2. Ensure 'Multiple Uploads' is disabled.
  3. Create and run a process using the conversational form.
  4. Upload a file and check:
    • The UI displays correctly without overlapping the chat content.
  5. Delete the file and check:
    • The UI reverts back to its initial state, removing the upload styling.

Multiple File Upload:

  1. Create a conversational form using a File Upload control.
  2. Ensure 'Multiple Uploads' is enabled.
  3. Create and run a process using the conversational form.
  4. Upload multiple files and check:
    • The UI displays correctly without overlapping the chat content.
  5. Delete the file and check:
    • The UI reverts back to its initial state, removing the upload styling.

Related Tickets and PRs:

FOUR-19684
FOUR-19264

Conversational Forms Package PR

ci:package-conversational-forms:observation/FOUR-19684

Copy link

cypress bot commented Oct 18, 2024

screen-builder    Run #1568

Run Properties:  status check passed Passed #1568  •  git commit 8ab00a6fe8: Fix UI Styling for Single and Multiple File Uploads in Conversational Forms
Project screen-builder
Branch Review observation/FOUR-19684
Run status status check passed Passed #1568
Run duration 08m 18s
Commit git commit 8ab00a6fe8: Fix UI Styling for Single and Multiple File Uploads in Conversational Forms
Committer Sanja
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 19
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 331
View all changes introduced in this branch ↗︎

Copy link
Contributor

@mcraeteisha mcraeteisha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!

@ryancooley ryancooley merged commit cf40c66 into release-2024-fall Oct 21, 2024
15 checks passed
@ryancooley ryancooley deleted the observation/FOUR-19684 branch October 21, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants