Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FOUR-19135 | Add Loading Spinner to Screen Templates Panel During Templates Fetch #1744

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

mcraeteisha
Copy link
Contributor

@mcraeteisha mcraeteisha commented Oct 17, 2024

Issue

Ticket: FOUR-19135

When fetching My Templates and Shared Templates via the Templates Panel, there is no indicator to show that the templates are loading or being fetched. If a user has a large number of templates, they may see a blank panel before the templates are loaded.

Solution

Add a <b-spinner> component to the My Templates and Shared Templates Panels, indicating that templates are being fetched/loaded.

How to Test

  1. Go to branch observation/FOUR-19135 in screen-builder.
  2. Go to Designer → Screens. Open a Screen to edit.
  3. Select 'Templates' from the top menu bar.
  4. When 'My Templates' are loading, a spinner should appear.
  5. Select 'Shared Templates'.
    • When the Shared Templates are loading, a spinner should appear.

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

Copy link

cypress bot commented Oct 17, 2024

screen-builder    Run #1517

Run Properties:  status check passed Passed #1517  •  git commit 057d38e1e5: FOUR-19135 | Add Loading Spinner to Screen Templates Panel During Templates Fetc...
Project screen-builder
Run status status check passed Passed #1517
Run duration 35m 23s
Commit git commit 057d38e1e5: FOUR-19135 | Add Loading Spinner to Screen Templates Panel During Templates Fetc...
Committer Teisha McRae
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 19
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 328

@ryancooley ryancooley merged commit a4339aa into release-2024-fall Oct 21, 2024
20 of 29 checks passed
@ryancooley ryancooley deleted the observation/FOUR-19135 branch October 21, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants