Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FOUR-19178: Add functionality so that only one Template can be selected at a time in the Panel #1743

Merged
merged 6 commits into from
Oct 22, 2024

Conversation

eiresendez
Copy link
Contributor

@eiresendez eiresendez commented Oct 17, 2024

Issue & Reproduction Steps

Expected behavior:

  • Template cards should have a toggle behavior, allowing only one to be open at a time.

Actual behavior:

  • Multiple template cards can currently be opened simultaneously.

Solution

  • A toggle functionality has been implemented for the template cards.

How to Test

  • Compile and test in core.

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

- Implemented the custom event 'toggle-active' in the child component to emit the active template ID.
- Added the 'setActiveTemplate' method in the parent component to handle active template changes when 'toggle-active' is triggered.
Copy link

cypress bot commented Oct 17, 2024

screen-builder    Run #1575

Run Properties:  status check passed Passed #1575  •  git commit 9eb3eb9daa: FOUR-19178: Add functionality so that only one Template can be selected at a tim...
Project screen-builder
Branch Review observation/FOUR-19178
Run status status check passed Passed #1575
Run duration 08m 13s
Commit git commit 9eb3eb9daa: FOUR-19178: Add functionality so that only one Template can be selected at a tim...
Committer Eleazar Resendez
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 19
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 331
View all changes introduced in this branch ↗︎

@mcraeteisha mcraeteisha self-requested a review October 18, 2024 16:37
Copy link
Contributor

@mcraeteisha mcraeteisha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!

@ryancooley ryancooley merged commit 344486d into release-2024-fall Oct 22, 2024
15 checks passed
@ryancooley ryancooley deleted the observation/FOUR-19178 branch October 22, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants