Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Error Handling for Template Application in Screen Builder #1736

Merged
merged 42 commits into from
Oct 15, 2024

Conversation

sanjacornelius
Copy link
Contributor

@sanjacornelius sanjacornelius commented Oct 8, 2024

Issue & Reproduction Steps

This PR enhances the error handling mechanism when applying a template to a screen. It ensures that users receive clear error messages instead of the generic 500 server error, improving overall user experience during template application failures.

Solution

  • Updated the error handling logic to return specific error messages by utilizing error.response.data.error.

How to Test

See Core PR for testing steps.

Related Tickets & Packages

ci:processmaker:observation/FOUR-19320
ci:package-versions:observation/FOUR-19320

.

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

mcraeteisha and others added 30 commits August 27, 2024 18:02
Add Screen Templates Section in Screen Builder
…ot installed

Also for use in screen-builder standalone
For cypress testing and screen-builder standalone
Instead of fetching from core
Or if a user is in screen-builder standalone
FOUR-18303 | Write Tests for Screen Templates Section
FOUR-18315 | Include Tests For Accurate Filtering and Display of Templates
Copy link

cypress bot commented Oct 8, 2024

screen-builder    Run #1457

Run Properties:  status check passed Passed #1457  •  git commit 0a9f616aa5: Improve Error Handling for Template Application in Screen Builder
Project screen-builder
Run status status check passed Passed #1457
Run duration 07m 37s
Commit git commit 0a9f616aa5: Improve Error Handling for Template Application in Screen Builder
Committer Sanja
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 19
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 301

@mcraeteisha mcraeteisha self-requested a review October 9, 2024 14:39
Copy link
Contributor

@mcraeteisha mcraeteisha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!

@sanjacornelius sanjacornelius changed the base branch from epic/FOUR-18012 to release-2024-fall October 9, 2024 18:48
@ryancooley ryancooley merged commit 8683126 into release-2024-fall Oct 15, 2024
49 of 62 checks passed
@ryancooley ryancooley deleted the observation/FOUR-19320 branch October 15, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants