Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[40754] Links added to a Display screen set as a "screen for completed" in Web entries are not working #1718

Merged
merged 1 commit into from
Sep 29, 2024
Merged

[40754] Links added to a Display screen set as a "screen for completed" in Web entries are not working #1718

merged 1 commit into from
Sep 29, 2024

Conversation

marcoAntonioNina
Copy link
Contributor

@marcoAntonioNina marcoAntonioNina commented Sep 27, 2024 •
edited by boliviacoca
Loading

Issue & Reproduction Steps

The Disabled variable remained set to true after clicking submit.

Expected behavior:
Links should be clickable
Actual behavior:
Can't click on links

Solution

  • Set disabled after load next assigned task

How to Test

step in ticket

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

ci:next
ci:deploy
[FOUR-19407]: https://processmaker.atlassian.net/browse/FOUR-19407?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ

@nolanpro nolanpro self-requested a review September 27, 2024 23:56
@cypress Cypress
Copy link

cypress bot commented Sep 28, 2024 •
edited
Loading

screen-builder    Run #1374

Run Properties:  status check passed Passed #1374  •  git commit 9b43f25939: [40754] Links added to a Display screen set as a "screen for completed" in Web e...
Project screen-builder
Branch Review bugfix/FOUR-19407
Run status status check passed Passed #1374
Run duration 07m 25s
Commit git commit 9b43f25939: [40754] Links added to a Display screen set as a "screen for completed" in Web e...
Committer Marco Antonio Nina Mena
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 19
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 296
View all changes introduced in this branch ↗︎

@ryancooley ryancooley merged commit d6d78db into next Sep 29, 2024
39 of 46 checks passed
@ryancooley ryancooley deleted the bugfix/FOUR-19407 branch September 29, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nolanpro nolanpro nolanpro approved these changes

Assignees
No one assigned
Labels
4.11.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@marcoAntonioNina @nolanpro @ryancooley @boliviacoca