Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/FOUR-18109: STORY Column Configuration for Collections y Record List #1710

Merged
merged 20 commits into from
Oct 4, 2024

Conversation

CarliPinell
Copy link
Contributor

@CarliPinell CarliPinell commented Sep 20, 2024

How to Test

  • Login PM4
  • Create new Screen
  • Drag Record List control
  • Choose new option Collection
  • Select Collection
  • Add columns from collection
  • Preview changes

Related Tickets & Packages

https://processmaker.atlassian.net/browse/FOUR-18109

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.
    ci:next

Copy link

cypress bot commented Sep 20, 2024

screen-builder    Run #1380

Run Properties:  status check passed Passed #1380  •  git commit 6280e1aa7c: Feature/FOUR-18109: STORY Column Configuration for Collections y Record List
Project screen-builder
Branch Review feature/FOUR-18109
Run status status check passed Passed #1380
Run duration 07m 26s
Commit git commit 6280e1aa7c: Feature/FOUR-18109: STORY Column Configuration for Collections y Record List
Committer CarliPinell
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 19
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 296
View all changes introduced in this branch ↗︎

Copy link
Contributor

@gustavobascope gustavobascope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@gustavobascope gustavobascope self-requested a review September 30, 2024 17:06
Copy link
Contributor

@gustavobascope gustavobascope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new configuration for the Record List Control needs a identifier and the test should call the configuration component with that identifier

image

Copy link
Contributor Author

@CarliPinell CarliPinell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gustavobascope Pagination.spec.js file was modified and e3e tests are working fine.

Copy link
Contributor

@gustavobascope gustavobascope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@nolanpro nolanpro merged commit 4e5bfba into feature/FOUR-18103 Oct 4, 2024
14 checks passed
@nolanpro nolanpro deleted the feature/FOUR-18109 branch October 4, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants