Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DO NOT MERGE, this is for testing #1668

Closed
wants to merge 76 commits into from
Closed

DO NOT MERGE, this is for testing #1668

wants to merge 76 commits into from

Conversation

caleeli
Copy link
Contributor

@caleeli caleeli commented Aug 9, 2024

Issue & Reproduction Steps

Expected behavior:

Actual behavior:

Solution

How to Test

Test the steps above

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

ci:next

fagubla and others added 22 commits July 25, 2024 11:25
@fagubla
The Home My Cases - The ellipisis is not showed
6e546e6 
fix-width
@pmPaulis
Merge branch 'next' into bugfix/FOUR-17354
316b2a6
@nolanpro
Set node id before loading the task for webentry
232f8f0
FOUR-17488: Back redirection on element destination with external URL…
d02582e 
… is not correct
fix code review notes
e083ed7
@devmiguelangel
fix: add activity completed event check on process update
8b320cc
@gproly
FOUR-17516 It is not possible to filter all sections from the search …
e75f994 
…within the screen
@fagubla
FOUR-17558:"Preview" in the "my tasks" filter is not displayed over t…
0de81e0 
…he corresponding task.
@fagubla
Update form-tasks.vue
988afad
@gproly
FOUR-17516 Fix issues
3d726d4
@nolanpro
Merge branch 'next' into observation/FOUR-17438
a5e79b8
@nolanpro
Start events do not have tasks, use optional chain
55151be
@nolanpro
Fix self service message flashing on submit
2ba8791
@nolanpro
Merge pull request #1660 from ProcessMaker/observation/FOUR-17438
133cd9f 
Set node id before loading the task for webentry
@caleeli
Get _parent from data when not found
8581384
@gustavobascope
Added a isVisible validation when the input is not visible in mobile
22cd00e
@gustavobascope
removed code debug messages
6108708
@ryancooley
Merge pull request #1661 from ProcessMaker/bugfix/FOUR-17503
5c2c9d2 
FOUR-17503  the gateway process for one of the parallel tasks in a parallel gateway process does not complete correctly
@ryancooley
Merge branch 'next' into observation/FOUR-17516
2a55e2b
@ryancooley
Merge branch 'next' into bugfix/FOUR-17558
00bae73
@ryancooley
Merge branch 'next' into bugfix/FOUR-17488
4a9c4d8
@ryancooley
Merge branch 'next' into bugfix/FOUR-17472
67c54d0
@caleeli caleeli changed the base branch from develop to comment-on-pr August 9, 2024 13:04
@caleeli caleeli changed the base branch from comment-on-pr to ci-develop August 9, 2024 13:05
@caleeli caleeli changed the base branch from ci-develop to next-1 August 9, 2024 13:07
@cypress Cypress
Copy link

cypress bot commented Aug 9, 2024 •
edited
Loading

screen-builder    Run #1236

Run Properties:  status check passed Passed #1236  •  git commit ae0ecd097e: DO NOT MERGE, this is for testing
Project screen-builder
Branch Review next
Run status status check passed Passed #1236
Run duration 08m 41s
Commit git commit ae0ecd097e: DO NOT MERGE, this is for testing
Committer David Callizaya
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 19
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 296
View all changes introduced in this branch ↗︎

pmPaulis and others added 3 commits August 9, 2024 10:57
@pmPaulis
Merge branch 'next' into bugfix/FOUR-17354
ae2ec23
@nolanpro
Fix next branch checker
4af6a08
@ryancooley
Merge pull request #1665 from ProcessMaker/bugfix/FOUR-17558
4077eb1 
FOUR-17558:"Preview" in the "my tasks" filter is not displayed over the corresponding task.
@processmaker-sonarqube ProcessMaker SonarQube
Copy link

Quality Gate failed Quality Gate failed

Failed conditions

1 New Code Smells (required ≤ 0)

See analysis details on SonarQube

Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

Rodrigo Quelca and others added 18 commits August 27, 2024 10:30
FOUR-18823: Welcome screen in element destination is not working
3a39d92
@nolanpro
Set nodeId for redirect events for webentry
e75ab0b
@ryancooley
Merge pull request #1674 from ProcessMaker/bugfix/FOUR-18851
389a09b 
Set nodeId for redirect events for webentry
fix merge conflicts
36617b3
restore bad merged nodeId
3568375
@ryancooley
Merge pull request #1673 from ProcessMaker/bugfix/FOUR-18823
9e0e91d 
FOUR-18823: Welcome screen in element destination is not working
@ryancooley
2.97.0
0025ccd
@ryancooley
2.98.0
6281550
@caleeli
Validate if task is loaded before to check allow interstitial
bdb30e3
FOUR-18859: User not assigned to the next task is redirected to task …
86e41a3 
…list by default
@ryancooley
Merge pull request #1676 from ProcessMaker/bugfix/FOUR-18861
6eb894e 
FOUR-18861 Fix Webentry issue routing to form task
@ryancooley
2.98.1
1d08846
@ryancooley
Merge pull request #1677 from ProcessMaker/bugfix/FOUR-18859
7943e98 
FOUR-18859: User not assigned to the next task is redirected to task …
@ryancooley
2.98.2
006bf52
@caleeli
User Story 1 Redirect to next task even without interstitial
af12361
@caleeli
Check if redirect is taskSource
f797f0f
@ryancooley
Merge pull request #1678 from ProcessMaker/bugfix/FOUR-18860
0ca9a5f 
FOUR-18860 Fix User completes a task and is assigned the next one is not redirected to form the next task
@ryancooley
2.98.3
ae0ecd0
@caleeli caleeli closed this Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@caleeli @fagubla @pmPaulis @nolanpro @devmiguelangel @gproly @gustavobascope @ryancooley