Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FOUR-17472 Fix reference to _parent in MultiInstance Tasks #1666

Merged
merged 2 commits into from
Aug 9, 2024

Conversation

caleeli
Copy link
Contributor

@caleeli caleeli commented Aug 8, 2024

Issue & Reproduction Steps

Can not access to _parent in tasks in MultiInstance Tasks

Expected behavior:

MultiInstance Task must be able to acces to _parent

Actual behavior:

MultiInstance Task must be able to acces to _parent

Solution

  • Fix reference to _parent in MultiInstance Tasks

How to Test

  • Import the attached process
  • Run the process
  • Follow the process, upload some files (images recommended) to the process
  • Continue to the MultiInstance Process
  • Verify the files you uploaded are visible
FixAccessToParentDocuments.mov

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

ci:next
ci:vue-form-elements:next

@caleeli caleeli requested a review from rodriquelca August 8, 2024 15:05
Copy link

cypress bot commented Aug 8, 2024



Test summary

296 0 19 0


Run details

Project screen-builder
Status Passed
Commit 67c54d0
Started Aug 9, 2024 2:48 PM
Ended Aug 9, 2024 2:56 PM
Duration 07:23 💡
OS Linux Ubuntu -
Browser Chrome 127

View run in Cypress Cloud ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

Copy link

Quality Gate passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No Coverage information No data about Coverage
0.0% 0.0% Duplication on New Code

See analysis details on SonarQube

@ryancooley ryancooley merged commit 4c24e73 into next Aug 9, 2024
37 of 39 checks passed
@ryancooley ryancooley deleted the bugfix/FOUR-17472 branch August 9, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants