Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FOUR-17465: Fix redirection issue when manualTask has been completed #1663

Merged
merged 10 commits into from
Aug 9, 2024

Conversation

estebangallego
Copy link
Contributor

@estebangallego estebangallego commented Aug 1, 2024

Issue & Reproduction Steps

An issue arises when completing a manual task, and the page fails to redirect. If a new case is started, the system redirects back to the Completed Task page, causing the page to enter into an infinite loop.

  • Import the Process attached to the ticket.
  • Run the Case
  • Select multiple reviewers within the form task
  • Screenshot 2024-08-01 at 2 45 07 PM
  • Navigate to cases and select on of the Tasks.
  • Screenshot 2024-08-01 at 2 46 17 PM
  • Complete the Task and do not move from the task
  • Start a new Case

Expected behavior:

After completing a manual task, the page should automatically redirect to the appropriate next step or task. When starting a new case, it should proceed without any issues.

Actual behavior:

Upon completing a manual task, the page does not redirect as expected. When starting a new case, the system redirects back to the Completed Task page, causing the page to enter into an infinite loop.

Solution

To resolve the issue, modify the code to ensure that after completing a manual task, the page checks the task status and reloads appropriately:

How to Test

Test the steps above and make sure the Expected behavior is met.

Related Tickets & Packages

  • Ticket: FOUR-17465
  • ci:next
  • ci:vue-form-elements:observation/FOUR-17347

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

Copy link

cypress bot commented Aug 1, 2024



Test summary

296 0 19 0


Run details

Project screen-builder
Status Passed
Commit 2de9185
Started Aug 2, 2024 12:05 PM
Ended Aug 2, 2024 12:12 PM
Duration 07:10 💡
OS Linux Ubuntu -
Browser Chrome 126

View run in Cypress Cloud ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

Copy link

@eiresendez eiresendez self-requested a review August 2, 2024 13:44
@ryancooley ryancooley merged commit 79458a4 into next Aug 9, 2024
34 of 40 checks passed
@ryancooley ryancooley deleted the observation/FOUR-17465 branch August 9, 2024 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants