Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set node id before loading the task for webentry #1660

Merged
merged 4 commits into from
Aug 6, 2024

Conversation

nolanpro
Copy link
Contributor

@nolanpro nolanpro commented Jul 29, 2024

Issue & Reproduction Steps

"Display next task to assignee" option is not redirecting to the next task and the submit button was not submitting to the correct endpoint (node id in the url was wrong)

Solution

  • this.nodeId needs to be set before loadTask because webentry needs to load the config with the new nodeId (using the beforeLoadTask hook)

How to Test

See jira issue

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

@nolanpro nolanpro requested a review from caleeli July 29, 2024 20:29
Copy link

cypress bot commented Jul 29, 2024



Test summary

256 21 17 17


Run details

Project screen-builder
Status Failed
Commit 2ba8791
Started Aug 6, 2024 10:49 PM
Ended Aug 6, 2024 10:56 PM
Duration 07:09 💡
OS Linux Ubuntu -
Browser Multiple

View run in Cypress Cloud ➡️


Failures

Run group: CI - Chrome (Linux, Chrome )
FormSelectList.spec.js Failed
1 Form Select List > Options from Data Connector (single value)
2 Form Select List > Options from Data Connector (object value)
SelectListMustache.spec.js Failed
1 select list mustache > Verify select list mustache + data source
2 select list mustache > Verify select list mustache + data source with custom key
SelectListCollection.spec.js Failed
1 select list mustache > Verify select list mustache + collection
2 select list mustache > Verify radio list mustache + collection
3 select list mustache > Verify check list mustache + collection
4 select list mustache > Verify multiselect list mustache + collection
5 select list mustache > Verify Load values in select list mustache + collection
6 select list mustache > Verify Load values in select list mustache + collection
This comment includes only the first 10 test failures. See all 21 failures in the Cypress Cloud.
Run group: CI - Chrome (Linux, Chrome )
FormSelectList.spec.js Failed
1 Form Select List > Options from Data Connector (single value)
2 Form Select List > Options from Data Connector (object value)
SelectListMustache.spec.js Failed
1 select list mustache > Verify select list mustache + data source
2 select list mustache > Verify select list mustache + data source with custom key
SelectListCollection.spec.js Failed
1 select list mustache > Verify select list mustache + collection
2 select list mustache > Verify radio list mustache + collection
3 select list mustache > Verify check list mustache + collection
4 select list mustache > Verify multiselect list mustache + collection
5 select list mustache > Verify Load values in select list mustache + collection
6 select list mustache > Verify Load values in select list mustache + collection
This comment includes only the first 10 test failures. See all 21 failures in the Cypress Cloud.

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

Copy link

@boliviacoca
Copy link
Contributor

The failing tests are related to: https://processmaker.atlassian.net/browse/FOUR-17347

@nolanpro nolanpro requested a review from devmiguelangel August 6, 2024 17:54
@nolanpro nolanpro changed the base branch from next to next-plg August 6, 2024 22:48
@nolanpro nolanpro merged commit 133cd9f into next-plg Aug 6, 2024
9 of 22 checks passed
@nolanpro nolanpro deleted the observation/FOUR-17438 branch August 6, 2024 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants