Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FOUR-17347 Return mock values in the correct format #1659

Merged
merged 8 commits into from
Aug 9, 2024

Conversation

nolanpro
Copy link
Contributor

@nolanpro nolanpro commented Jul 25, 2024

Issue & Reproduction Steps

Standalone screen builder was not returning mock data connector response for the select list. This was causing 2 tests to fail.

Expected behavior:
Should show show mock values

Actual behavior:
Not showing any results

Solution

  • The getDataSource has 2 possible returns and only one was formatting the response correctly.

How to Test

  • Use a data connector select list with default values in standalone mode.

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

ci:next
ci:vue-form-elements:observation/FOUR-17347

Copy link

cypress bot commented Jul 25, 2024



Test summary

296 0 19 0


Run details

Project screen-builder
Status Passed
Commit 32aeb51
Started Jul 31, 2024 4:03 PM
Ended Jul 31, 2024 4:11 PM
Duration 07:17 💡
OS Linux Ubuntu -
Browser Chrome 126

View run in Cypress Cloud ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

@nolanpro nolanpro requested a review from pmPaulis July 25, 2024 18:57
@nolanpro nolanpro force-pushed the observation/FOUR-17347 branch from 6f2ad06 to 405c61b Compare July 30, 2024 22:04
Update ci.yml

Update ci.yml

Update ci.yml
@nolanpro nolanpro force-pushed the observation/FOUR-17347 branch 4 times, most recently from b1fea2b to 801c6db Compare July 31, 2024 16:00
@nolanpro nolanpro force-pushed the observation/FOUR-17347 branch from 801c6db to 32aeb51 Compare July 31, 2024 16:02
Copy link

@pmPaulis pmPaulis requested a review from caleeli July 31, 2024 18:26
@ryancooley ryancooley merged commit b4f58d1 into next Aug 9, 2024
15 checks passed
@ryancooley ryancooley deleted the observation/FOUR-17347 branch August 9, 2024 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants