Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FOUR-17258 Fix Task Initialization in Webentries #1657

Merged
merged 4 commits into from
Jul 25, 2024
Merged

Conversation

caleeli
Copy link
Contributor

@caleeli caleeli commented Jul 24, 2024

Fix Task Initialization in Webentries

When a webentry is opened, it does not count with request or task, this caused error in the Task component new changes. Also the screen kept disabled because of that.
Also there is a problem in the screens endpoint when selecting an screen.

Solution

  • Fix the initialization of the Task considering it could not have a request
  • Disable the screen at the begining only when a request is present
  • Fix screen endpoint and add some tests to validate it.
WebEntryFix.mov

How to Test

  • Create a process with an anonnymous webentry
    • Variations: With interstitial screen
    • Variation: Without interstitial screen
  • Open the web entry
  • Complete the form

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

ci:next

@caleeli caleeli changed the base branch from develop to next July 24, 2024 22:33
Copy link

cypress bot commented Jul 24, 2024

2 failed tests on run #1085 ↗︎

2 68 13 0 Flakiness 0

Details:

FOUR-17258 Fix Task Initialization in Webentries
Project: screen-builder Commit: 6cf6ebdfdf
Status: Failed Duration: 03:06 💡
Started: Jul 25, 2024 2:21 PM Ended: Jul 25, 2024 2:24 PM
Failed  FormSelectList.spec.js • 2 failed tests • CI - Chrome

View Output

Test Artifacts
Form Select List > Options from Data Connector (single value) Test Replay Screenshots
Form Select List > Options from Data Connector (object value) Test Replay Screenshots
Failed  FormInput.spec.js • 0 failed tests • CI - Chrome

View Output

Test Artifacts
Failed  ComplexScreen.spec.js • 0 failed tests • CI - Chrome

View Output

Test Artifacts
Failed  Watchers.spec.js • 0 failed tests • CI - Chrome

View Output

Test Artifacts
Failed  WatchersDragAndDrop.spec.js • 0 failed tests • CI - Chrome

View Output

Test Artifacts

The first 5 failed specs are shown, see all 79 specs in Cypress Cloud.

Review all test suite changes for PR #1657 ↗︎

@caleeli caleeli requested review from nolanpro, pmPaulis, rodriquelca and devmiguelangel and removed request for pmPaulis July 25, 2024 12:27
Copy link

@ryancooley ryancooley merged commit f59d70e into next Jul 25, 2024
13 of 15 checks passed
@ryancooley ryancooley deleted the bugfix/FOUR-17258 branch July 25, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants