Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FOUR-17261: When the calc has bypass activated, the content of the entire form is not displayed #1653

Merged
merged 4 commits into from
Jul 24, 2024

Conversation

rodriquelca
Copy link
Contributor

@rodriquelca rodriquelca commented Jul 22, 2024

Issue & Reproduction Steps

hen the calc has bypass activated, the content of the entire form is not displayed
Expected behavior:
The content of the screen should be displayed, only the calcs values ​​should not be displayed
Actual behavior:
When the calc has bypass activated, the content of the entire form is not displayed (For example: New submit Button is not showed)

Solution

  • improve isComputedVariable method to support byPass computed property

How to Test

Detailed in the related ticket

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.
    c:next

Copy link

cypress bot commented Jul 22, 2024

Passing run #1059 ↗︎

0 292 19 0 Flakiness 0

Details:

FOUR-17261: When the calc has bypass activated, the content of the entire form i...
Project: screen-builder Commit: cb0149ad5f
Status: Passed Duration: 07:16 💡
Started: Jul 22, 2024 3:50 PM Ended: Jul 22, 2024 3:57 PM

Review all test suite changes for PR #1653 ↗︎

Copy link

@ryancooley ryancooley merged commit 6d8ab13 into next Jul 24, 2024
23 of 27 checks passed
@ryancooley ryancooley deleted the bugfix/FOUR-17261 branch July 24, 2024 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants