Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FOUR-17102 calcs type should change from expression to formula #1641

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

devmiguelangel
Copy link
Contributor

@devmiguelangel devmiguelangel commented Jul 10, 2024

Issue & Reproduction Steps

Expected behavior:
Calcs type should change from expression to Formula

Actual behavior:
When you create a calculation from a formula, the type displays as an expression

Solution

  • Add a callback to fields property

How to Test

  1. Import the attached screen
  2. Search screen and edit
  3. Click on calcs button

Related Tickets & Packages

FOUR-17102

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

ci:next

@devmiguelangel devmiguelangel self-assigned this Jul 10, 2024
Copy link

cypress bot commented Jul 10, 2024

Passing run #1014 ↗︎

0 292 19 0 Flakiness 0

Details:

FOUR-17102 calcs type should change from expression to formula
Project: screen-builder Commit: f4c40f6f27
Status: Passed Duration: 30:11 💡
Started: Jul 10, 2024 8:17 PM Ended: Jul 10, 2024 8:48 PM

Review all test suite changes for PR #1641 ↗︎

Copy link

@caleeli caleeli merged commit c85441d into feature/FOUR-13452 Jul 11, 2024
25 of 28 checks passed
@caleeli caleeli deleted the bugfix/FOUR-17102 branch July 11, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants