Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FOUR-17044 an add button appears when doing d&d #1639

Merged
merged 5 commits into from
Jul 11, 2024

Conversation

devmiguelangel
Copy link
Contributor

@devmiguelangel devmiguelangel commented Jul 9, 2024

Issue & Reproduction Steps

Expected behavior:
An add button should not appear when doing drag and drop in Calcs and watchers

Actual behavior:
An add button appears when doing drag and drop in Calcs and watchers

Solution

  • Hide the plus icon
  • Add tooltips to edit and delete buttons

How to Test

  1. Import attached secreen
  2. Go to designer tab
  3. Search screen and edit
  4. First scenario: Calcs
  5. Click on Calcs button
  6. Drag and drop last Calc(C3) to top

Related Tickets & Packages

FOUR-17044

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

ci:next

@devmiguelangel devmiguelangel self-assigned this Jul 9, 2024
Copy link

cypress bot commented Jul 9, 2024

Passing run #1018 ↗︎

0 292 19 0 Flakiness 0

Details:

FOUR-17044 an add button appears when doing d&d
Project: screen-builder Commit: df17058ad8
Status: Passed Duration: 30:40 💡
Started: Jul 11, 2024 12:35 PM Ended: Jul 11, 2024 1:06 PM

Review all test suite changes for PR #1639 ↗︎

@caleeli caleeli merged commit 4d53e82 into feature/FOUR-13452 Jul 11, 2024
16 checks passed
@caleeli caleeli deleted the bugfix/FOUR-17044 branch July 11, 2024 13:50
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants