Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature/FOUR-15039: The styles of the options in Welcome Screen are not the same as in figma #1573

Merged
merged 8 commits into from
Apr 18, 2024
Merged

feature/FOUR-15039: The styles of the options in Welcome Screen are not the same as in figma #1573

merged 8 commits into from
Apr 18, 2024

Conversation

luNunezProcessmaker
Copy link
Contributor

@luNunezProcessmaker luNunezProcessmaker commented Apr 16, 2024 •
edited by fagubla
Loading

Issue & Reproduction Steps

  1. The order of the options
  2. The spacing between options
  3. The width of the tool tip is much narrower

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

ci:next
ci:deploy
ci:package/dynamic-ui:feature/FOUR-15039

@cypress Cypress
Copy link

cypress bot commented Apr 16, 2024 •
edited
Loading

Passing run #644 ↗︎

0 264 19 0 Flakiness 0

Details:

feature/FOUR-15039: The styles of the options in Welcome Screen are not the same...
Project: screen-builder Commit: 0bd3ce5862
Status: Passed Duration: 06:40 💡
Started: Apr 17, 2024 3:13 PM Ended: Apr 17, 2024 3:19 PM

Review all test suite changes for PR #1573 ↗︎

@tokensPM
Copy link

QA server K8S was successfully deployed https://ci-49807424d5.engk8s.processmaker.net

@tokensPM
Copy link

QA server K8S was successfully deployed https://ci-49807424d5.engk8s.processmaker.net

@tokensPM
Copy link

QA server K8S was successfully deployed https://ci-49807424d5.engk8s.processmaker.net

@processmaker-sonarqube ProcessMaker SonarQube
Copy link

Quality Gate passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No Coverage information No data about Coverage
0.0% 0.0% Duplication on New Code

See analysis details on SonarQube

@tokensPM
Copy link

QA server K8S was successfully deployed https://ci-49807424d5.engk8s.processmaker.net

@ryancooley ryancooley merged commit 296609c into next Apr 18, 2024
24 of 27 checks passed
@ryancooley ryancooley deleted the feature/FOUR-15039 branch April 18, 2024 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fagubla fagubla fagubla approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@luNunezProcessmaker @tokensPM @fagubla @ryancooley