Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[36258 ]Interstitial pages load twice #1567

Merged
merged 3 commits into from
Mar 27, 2024
Merged

[36258 ]Interstitial pages load twice #1567

merged 3 commits into from
Mar 27, 2024

Conversation

marcoAntonioNina
Copy link
Contributor

@marcoAntonioNina marcoAntonioNina commented Mar 22, 2024

Issue & Reproduction Steps

When you have a process with multiple thread levels and interstitial enabled, the interstitial is loaded twice.

Solution

  • check if the activate event has already arrived.

How to Test

In order to reproduce the problem you need to add a 2 second sleep to the file
ProcessMaker/Models/ProcessRequest.php
in the notifyProcessUpdated function before sending the event.
In this way a delay is created in the sending of the events.

create a case and then derive it to check that the interstitial is not loaded twice.

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

Copy link

cypress bot commented Mar 22, 2024

Passing run #615 ↗︎

0 263 19 0 Flakiness 0

Details:

[36258 ]Interstitial pages load twice
Project: screen-builder Commit: 708cafc657
Status: Passed Duration: 27:11 💡
Started: Mar 27, 2024 12:56 PM Ended: Mar 27, 2024 1:23 PM

Review all test suite changes for PR #1567 ↗︎

@marcoAntonioNina marcoAntonioNina changed the base branch from next to develop March 22, 2024 22:02
Copy link

@ryancooley ryancooley merged commit 549e676 into develop Mar 27, 2024
30 of 37 checks passed
@ryancooley ryancooley deleted the bugfix/FOUR-14542 branch March 27, 2024 20:21
ryancooley added a commit that referenced this pull request Mar 27, 2024
[36258 ]Interstitial pages load twice
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants