Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send information about what button was clicked when submitting #1564

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

nolanpro
Copy link
Contributor

Issue & Reproduction Steps

See https://processmaker.atlassian.net/browse/FOUR-14411

Solution

  • Emit button info as a 3rd parameter in the submit event

How to Test

  • Create an inbox rule, fill form data, and click a submit button. Ensure the correct submit button is shown on the inbox rule config.

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

@nolanpro nolanpro changed the base branch from develop to next March 14, 2024 18:47
Copy link

cypress bot commented Mar 14, 2024

Passing run #590 ↗︎

0 264 19 0 Flakiness 0

Details:

Send information about what button was clicked when submitting
Project: screen-builder Commit: f80804dae3
Status: Passed Duration: 06:51 💡
Started: Mar 14, 2024 6:48 PM Ended: Mar 14, 2024 6:55 PM

Review all test suite changes for PR #1564 ↗︎

Copy link

@nolanpro nolanpro requested a review from gproly March 14, 2024 18:59
@ryancooley ryancooley merged commit 75ee9c6 into next Mar 15, 2024
15 checks passed
@ryancooley ryancooley deleted the feature/FOUR-14411 branch March 15, 2024 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants