Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FOUR-14341 Fix Not all tabs are shown in Settings #1561

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

caleeli
Copy link
Contributor

@caleeli caleeli commented Mar 6, 2024

Issue & Reproduction Steps

Not all tabs are shown in Settings.

Solution

  • Restore default behavior of tab wrap.
  • Add a css class to apply nowrap to SB tabs only

How to Test

  1. Login
  2. Go to admin tab
  3. Click on Setting option in sidebar menu

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

ci:deploy
ci:next

Copy link

cypress bot commented Mar 6, 2024

Passing run #575 ↗︎

0 264 19 0 Flakiness 0

Details:

FOUR-14341 Fix Not all tabs are shown in Settings
Project: screen-builder Commit: 56abd5e89e
Status: Passed Duration: 28:44 💡
Started: Mar 6, 2024 2:04 PM Ended: Mar 6, 2024 2:32 PM

Review all test suite changes for PR #1561 ↗︎

@tokensPM
Copy link

tokensPM commented Mar 6, 2024

QA server K8S was successfully deployed https://ci-10e883740e.engk8s.processmaker.net

Copy link

Quality Gate passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No Coverage information No data about Coverage
0.0% 0.0% Duplication on New Code

See analysis details on SonarQube

@ryancooley ryancooley merged commit 95a00ff into next Mar 7, 2024
16 checks passed
@ryancooley ryancooley deleted the bugfix/FOUR-14341 branch March 7, 2024 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants