Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FOUR-14287 Fix Reordering pages in the modal is not reflected in the menu list #1555

Merged
merged 7 commits into from
Mar 1, 2024

Conversation

caleeli
Copy link
Contributor

@caleeli caleeli commented Feb 28, 2024

Reordering pages in the modal is not reflected in the menu list

Solution

  • Add a calculated property with the sorted pages
  • Use the object reference to the page to select the page

How to Test

  1. Create multiple pages
  2. Sort the pages
  3. Use the drop-down of pages check it has the same order as the step 2

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

ci:next

@caleeli caleeli requested a review from rodriquelca February 28, 2024 19:56
Copy link

cypress bot commented Feb 28, 2024

Passing run #562 ↗︎

0 264 19 0 Flakiness 0

Details:

FOUR-14287 Fix Reordering pages in the modal is not reflected in the menu list
Project: screen-builder Commit: 3fee27cdc5
Status: Passed Duration: 06:45 💡
Started: Feb 29, 2024 5:42 PM Ended: Feb 29, 2024 5:49 PM

Review all test suite changes for PR #1555 ↗︎

Base automatically changed from feature/FOUR-13446 to next February 28, 2024 22:45
Copy link

@ryancooley ryancooley merged commit 346c924 into next Mar 1, 2024
15 checks passed
@ryancooley ryancooley deleted the bugfix/FOUR-14287 branch March 1, 2024 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants