Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FOUR-13078: Clicking in view all request shows server error #1529

Merged
merged 7 commits into from
Feb 6, 2024

Conversation

rodriquelca
Copy link
Contributor

@rodriquelca rodriquelca commented Feb 5, 2024

Issue & Reproduction Steps

Expected behavior:
When an user clicks in view all request it should see all the requests.
Actual behavior:
Clicking in view all request shows server error

Solution

  • improve empty form url
  • add server url as a global parameter

How to Test

Test the steps above

  1. Create a new user.
  2. log in with the user, and make sure you are in the default home page dashboard
  3. If there are no requests or tasks available Click to view all requests or tasks
  4. See the error.
  5. If your user has tasks and/or requests you won’t see the links but you can also try these URLs:

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

ci:next

Copy link

cypress bot commented Feb 5, 2024

Passing run #386 ↗︎

0 277 5 0 Flakiness 0

Details:

FOUR-13078: Clicking in view all request shows server error
Project: screen-builder Commit: 7342244d91
Status: Passed Duration: 28:10 💡
Started: Feb 6, 2024 3:29 PM Ended: Feb 6, 2024 3:57 PM

Review all test suite changes for PR #1529 ↗︎

src/components/renderer/form-requests.vue Outdated Show resolved Hide resolved
src/components/renderer/form-tasks.vue Outdated Show resolved Hide resolved
@nolanpro nolanpro requested a review from fagubla February 5, 2024 18:20
Copy link

@ryancooley ryancooley merged commit 6f51502 into next Feb 6, 2024
13 checks passed
@ryancooley ryancooley deleted the bugfix/FOUR-13078 branch February 6, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants