Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/FOUR-10752: [33909] Upload file control showing as required even when file is present #1527

Merged
merged 4 commits into from
Feb 5, 2024

Conversation

agustinbusso
Copy link
Contributor

@agustinbusso agustinbusso commented Feb 2, 2024

Issue & Reproduction Steps

Steps to Reproduce:

  • Create a screen with the following elements:
  • A Record List containing a File Upload element (as required).
  • Use the screen in a Web entry (Start Event).
  • Initiate the request through the web entry.
  • Click the ADD button in the Record List.
  • Select a PDF file and click the CANCEL button in the Record List.
  • Click the ADD button in the Record List again and select the PDF file you wanted to upload previously.
  • Select the OK option in the Record List.

Current Behavior:

You may notice that you cannot add the record to the Record List, and it marks the uploaded document as required, even though it has been uploaded.

For more information, please watch the video attached in the FOUR-10752 ticket:

Solution

  • This is a hacky solution due a reactivity problem with the component vue-simple-uploader Show and hide the uploader component to force refresh it when showing the recordlist modal

Working video

Grabacion.de.pantalla.2024-02-02.a.la.s.16.57.13.mov

How to Test

Test the steps above

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

ci:next
ci:deploy

Copy link

cypress bot commented Feb 2, 2024

Passing run #372 ↗︎

0 277 5 0 Flakiness 0

Details:

Bugfix/FOUR-10752: [33909] Upload file control showing as required even when fil...
Project: screen-builder Commit: 93bf4b18d1
Status: Passed Duration: 06:55 💡
Started: Feb 5, 2024 1:05 PM Ended: Feb 5, 2024 1:12 PM

Review all test suite changes for PR #1527 ↗︎

@tokensPM
Copy link

tokensPM commented Feb 2, 2024

QA server K8S was successfully deployed https://ci-70377f304d.engk8s.processmaker.net

Copy link

@tokensPM
Copy link

tokensPM commented Feb 5, 2024

QA server K8S was successfully deployed https://ci-70377f304d.engk8s.processmaker.net

@ryancooley ryancooley merged commit 1acc7c6 into next Feb 5, 2024
13 checks passed
@ryancooley ryancooley deleted the bugfix/FOUR-10752 branch February 5, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants