Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/FOUR-10753: [33904] File name uploaded via web entry and record list is saved with web entry data #1525

Merged
merged 3 commits into from
Feb 2, 2024

Conversation

agustinbusso
Copy link
Contributor

@agustinbusso agustinbusso commented Feb 2, 2024

Issue & Reproduction Steps

Steps to Reproduce

  • Create a process with web entry in the first task.
  • Create a screen with a record list in the record list make sure to have a file upload field.
  • Set the screen in the web entry.
  • Start a request with the web entry.
  • Add a new record to the record list.
  • Upload any files in the file upload field in my example I uploaded 2 files already-exists.png and simple-report-example.png.

At this point, you will see that the name of the file is displayed alongside the web entry ID in the record list.

Current Behavior
The record list displays the file name with information about the web entry as a prefix.

Expected Behavior
The record list should display only the file name without any prefixes.

Solution

  • Created a template to render in the datatable the filename obtained form PMOverride variable.

Working videos

  • Single fileupload
Grabacion.de.pantalla.2024-02-02.a.la.s.11.51.40.mov
  • Multiple fileupload
Grabacion.de.pantalla.2024-02-02.a.la.s.11.50.35.mov

How to Test

Test the steps above

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

ci:next
ci:deploy

@tokensPM
Copy link

tokensPM commented Feb 2, 2024

QA server K8S was successfully deployed https://ci-53d66ec9b7.engk8s.processmaker.net

@CarliPinell
Copy link
Contributor

CarliPinell commented Feb 2, 2024

Some tests were done successfully in https://ci-53d66ec9b7.engk8s.processmaker.net/ environment.
Screenshot from 2024-02-02 15-56-05

image

Copy link

processmaker-sonarqube bot commented Feb 2, 2024

Copy link

cypress bot commented Feb 2, 2024

Passing run #360 ↗︎

0 277 5 0 Flakiness 0

Details:

Bugfix/FOUR-10753: [33904] File name uploaded via web entry and record list is s...
Project: screen-builder Commit: da73486928
Status: Passed Duration: 06:47 💡
Started: Feb 2, 2024 8:02 PM Ended: Feb 2, 2024 8:09 PM

Review all test suite changes for PR #1525 ↗︎

@tokensPM
Copy link

tokensPM commented Feb 2, 2024

QA server K8S was successfully deployed https://ci-53d66ec9b7.engk8s.processmaker.net

@ryancooley ryancooley merged commit 0d4c1e3 into next Feb 2, 2024
13 checks passed
@ryancooley ryancooley deleted the bugfix/FOUR-10753 branch February 2, 2024 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants