Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FOUR-13065 AIAssistant was coming as undefined due to a watcher race-condition issue #1503

Merged
merged 4 commits into from
Jan 3, 2024

Conversation

josechirivella
Copy link
Contributor

Issue & Reproduction Steps

Expected behavior:
No errors should appear when using Screen Builder

Actual behavior:
There was an error appearing about AIAssistant being undefined due to a race condition where the watcher was being executed AFTER rendering and we needed that watcher to be executed immediatly when rendering.

Solution

  • Added immediate to be true on watcher
  • Re-indent
  • Added the filteredGroupedControls varaible to the v-data since it was missing.

How to Test

Test the steps above

  • Open a Screen of type FORM and no errors should appear in the console.

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

ci:deploy
ci:next

* Added the filteredControlsGrouped to the v-data since it was missing
* Re-indenting
@josechirivella josechirivella self-assigned this Jan 3, 2024
@josechirivella josechirivella changed the title bugfix/FOUR-13065 FOUR-13065 AIAssistant was coming as undefined due to a watcher race-condition issue Jan 3, 2024
@josechirivella josechirivella changed the base branch from next to develop January 3, 2024 18:15
@josechirivella josechirivella changed the base branch from develop to next January 3, 2024 18:15
@josechirivella josechirivella deleted the bugfix/FOUR-13065 branch January 3, 2024 18:16
@josechirivella josechirivella restored the bugfix/FOUR-13065 branch January 3, 2024 18:18
@josechirivella josechirivella reopened this Jan 3, 2024
Copy link

cypress bot commented Jan 3, 2024

Passing run #205 ↗︎

0 269 12 0 Flakiness 0

Details:

Merge 66b77e0 into cb4fb82...
Project: screen-builder Commit: 00720d1e81 ℹ️
Status: Passed Duration: 07:14 💡
Started: Jan 3, 2024 6:46 PM Ended: Jan 3, 2024 6:54 PM

Review all test suite changes for PR #1503 ↗︎

* Added the filteredControlsGrouped to the v-data since it was missing
* Re-indenting
Copy link

@tokensPM
Copy link

tokensPM commented Jan 3, 2024

QA server was successfully deployed https://ci-9c78b16295.eng.processmaker.net

@ryancooley ryancooley merged commit fc33577 into next Jan 3, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants