Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FOUR-12447 Cypress v13 #1501

Closed
wants to merge 17 commits into from
Closed

FOUR-12447 Cypress v13 #1501

wants to merge 17 commits into from

Conversation

josechirivella
Copy link
Contributor

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

@josechirivella josechirivella self-assigned this Dec 22, 2023
@josechirivella josechirivella changed the base branch from develop to next December 22, 2023 21:27
Copy link

cypress bot commented Dec 22, 2023

22 failed tests on run #295 ↗︎

22 24 0 0 Flakiness 0

Details:

Merge 3df5026 into 4e75c28...
Project: screen-builder Commit: 87b0812966 ℹ️
Status: Failed Duration: 02:46 💡
Started: Jan 28, 2024 8:18 PM Ended: Jan 28, 2024 8:21 PM
Failed  DatePicker.spec.js • 4 failed tests

View Output

Test Artifacts
Date Picker > Date picker with default value should show the default value on input and data Test Replay Screenshots
Date Picker > Date picker with minDate equal or less than first datepicker should return the current date Test Replay Screenshots
Date Picker > Date picker with maxDate equal or greater than first datepicker should return the current date Test Replay Screenshots
Date Picker > Date time picker with minDate less than first datepicker should return null data Test Replay Screenshots
Failed  Task.spec.js • 10 failed tests

View Output

Test Artifacts
Task component > Task inside a Request Test Replay Screenshots
Task component > Completes the Task Test Replay Screenshots
Task component > Progresses to the interstitial screen Test Replay Screenshots
Task component > It updates the PM4ConfigOverrides Test Replay Screenshots
Task component > Task with display next assigned task checked with another pending task in same request should redirect to the next task of same request Test Replay Screenshots
Task component > Task with display next assigned task checked in subprocess and no pending task and status closed or open should redirect to parent requests Test Replay Screenshots
Task component > Task with display next assigned task checked in different process request should redirect to the next task of parent request Test Replay Screenshots
Task component > Task with display next assigned task unchecked should redirect to tasks list Test Replay Screenshots
Task component > Process without pending task should redirect to request Test Replay Screenshots
Task component > Subprocess without pending task should redirect to parent request Test Replay Screenshots
Failed  Loop.spec.js • 4 failed tests

View Output

Test Artifacts
Loop control > Verify validation on visible fields Test Replay Screenshots
Loop control > Verify validation with multicolumn Test Replay Screenshots
Loop control > Verify validation with nested loop Test Replay Screenshots
Loop control > Verify validation with nested screen Test Replay Screenshots
Failed  CustomCss.spec.js • 1 failed test

View Output

Test Artifacts
Custom CSS > Closes Modal Test Replay Screenshots
Failed  ComplexScreen.spec.js • 3 failed tests

View Output

Test Artifacts
Complex screen > Fill page 2 Test Replay Screenshots
Complex screen > Fill page 3 Test Replay Screenshots
Complex screen > Fill page 4 Test Replay Screenshots

The first 5 failed specs are shown, see all 79 specs in Cypress Cloud.

Review all test suite changes for PR #1501 ↗︎

josechirivella and others added 8 commits December 22, 2023 15:40
# Conflicts:
#	.github/workflows/ci.yml
#	babel.config.js
#	cypress.json
#	package-lock.json
#	package.json
#	tests/e2e/specs/DeviceVisivilityInspector.spec.js
#	tests/e2e/specs/FileUpload.spec.js
#	tests/e2e/specs/RecordList.spec.js
Copy link

Quality Gate failed Quality Gate failed

Failed conditions

48.3% 48.3% Duplication on New Code (required ≤ 20%)
8 New Bugs (required ≤ 0)
C Reliability Rating on New Code (required ≥ A)
10 New Code Smells (required ≤ 0)

See analysis details on SonarQube

Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant