Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FOUR-12891 / FOUR-12881 Fix Balloon position and improvement of Control Menu for Display Screen #1499

Merged
merged 16 commits into from
Jan 9, 2024
Merged

FOUR-12891 / FOUR-12881 Fix Balloon position and improvement of Control Menu for Display Screen #1499

merged 16 commits into from
Jan 9, 2024

Conversation

pmoskrojas
Copy link
Contributor

@pmoskrojas pmoskrojas commented Dec 19, 2023 •
edited by nolanpro
Loading

Issue & Reproduction Steps

https://processmaker.atlassian.net/browse/FOUR-12891
https://processmaker.atlassian.net/browse/FOUR-12881

Expected behavior:

Actual behavior:

Solution

How to Test

Test the steps above

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.
    ..

@cypress Cypress
Copy link

cypress bot commented Dec 19, 2023 •
edited
Loading

Passing run #233 ↗︎

0 267 14 0 Flakiness 0

Details:

Merge 1e10dd4 into 250731c...
Project: screen-builder Commit: 03fa63c7d6 ℹ️
Status: Passed Duration: 06:55 💡
Started: Jan 9, 2024 12:05 AM Ended: Jan 9, 2024 12:12 AM

Review all test suite changes for PR #1499 ↗︎

gustavobascope
gustavobascope reviewed Dec 19, 2023
View reviewed changes
Copy link
Contributor

@gustavobascope gustavobascope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Advance accordion arrow is backwards

image

gustavobascope
gustavobascope approved these changes Dec 20, 2023
View reviewed changes
Copy link
Contributor

@gustavobascope gustavobascope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The observation was fixed

@nolanpro nolanpro mentioned this pull request Jan 3, 2024
Merged
@nolanpro nolanpro mentioned this pull request Jan 5, 2024
Closed
@processmaker-sonarqube ProcessMaker SonarQube
Copy link

Quality Gate passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
0.0% 0.0% Coverage on New Code
5.1% 5.1% Duplication on New Code

See analysis details on SonarQube

@ryancooley ryancooley merged commit 412e9a9 into next Jan 9, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gustavobascope gustavobascope gustavobascope approved these changes

@boliviacoca boliviacoca boliviacoca approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@pmoskrojas @boliviacoca @gustavobascope @ryancooley @karlOS123testing @nolanpro