Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FOUR-12665 The interstitial screen in the start event stops working #1491

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

devmiguelangel
Copy link
Contributor

@devmiguelangel devmiguelangel commented Dec 4, 2023

Issue & Reproduction Steps

Currently, if the interstitial screen is configured in the start event, it never shows up and the request’s task is shown directly. We have noticed that this happens with a process with more than 50 elements (meaning tasks, events, lines, pools, etc.) at the beginning you will see this behavior intermittently but if you increase the number of elements (>50) you will see it permanently.
If you reduce the number of elements you will see that the interstitial works normally.

Solution

  • Check if the interstitial screen is set

Related Tickets & Packages

FOUR-12665
ProcessMaker/processmaker#5753

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

Copy link

Copy link

cypress bot commented Dec 4, 2023

Passing run #164 ↗︎

0 270 12 0 Flakiness 0

Details:

Merge 6487d47 into 7f5a95d...
Project: screen-builder Commit: c8b1a3d597 ℹ️
Status: Passed Duration: 07:05 💡
Started: Dec 4, 2023 6:58 PM Ended: Dec 4, 2023 7:06 PM

Review all test suite changes for PR #1491 ↗︎

@ryancooley ryancooley merged commit 2f987d8 into develop Dec 4, 2023
28 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants