Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add openAcordeon method and update tests #1490

Merged
merged 1 commit into from
Dec 5, 2023

Conversation

karlOS123testing
Copy link
Contributor

fix some test cases in order to open the acordeon

Copy link

SonarQube Quality Gate

Quality Gate failed

Failed condition 40.4% 40.38% Duplicated Lines (%) on New Code (is greater than 20%)

See analysis details on SonarQube

Copy link

cypress bot commented Dec 1, 2023

25 failed tests on run #160 ↗︎

25 242 12 2 Flakiness 0

Details:

Merge e9e3b99 into 1aaf3ce...
Project: screen-builder Commit: 4288f40bde ℹ️
Status: Failed Duration: 07:25 💡
Started: Dec 1, 2023 1:08 PM Ended: Dec 1, 2023 1:16 PM
Failed  DatePicker.spec.js • 1 failed test

View Output

Test Artifacts
Date Picker > Date picker with Required validation shouldn't allow the user to submit the date if empty Screenshots
Failed  DeviceVisivilityInspector.spec.js • 3 failed tests

View Output

Test Artifacts
Device Visiblility Inspector > Verify Device Visibility of controls inside a loop Screenshots
Device Visiblility Inspector > Verify Device Visibility of controls inside a table Screenshots
Device Visiblility Inspector > Verify Device Visibility of controls inside a table mobile Screenshots
Failed  Loop.spec.js • 5 failed tests

View Output

Test Artifacts
Loop control > Input inside loop Screenshots
Loop control > Verify validation on visible fields Screenshots
Loop control > Verify validation with multicolumn Screenshots
Loop control > Verify validation with nested loop Screenshots
Loop control > Verify validation with nested screen Screenshots
Failed  MultiColumn.spec.js • 2 failed tests

View Output

Test Artifacts
MultiColumns > Configure using JSON Screenshots
MultiColumns > Configure using columns configuration Screenshots
Failed  Pagination.spec.js • 1 failed test

View Output

Test Artifacts
Pagination > Should Not Be Visible Screenshots

The first 5 failed specs are shown, see all 15 specs in Cypress Cloud.

Review all test suite changes for PR #1490 ↗︎

Copy link
Contributor

@pmoskrojas pmoskrojas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the changes related to the new Accordion component in the Control Menu, perfectly comply with what is required on the Cypress test. Therefore, the work is excellent and approved.

@pmoskrojas pmoskrojas merged commit 7e30f16 into epic/FOUR-11574 Dec 5, 2023
7 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants