Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FOUR-11744 / FOUR-11895 / FOUR-12198 #1488

Merged
merged 16 commits into from
Dec 11, 2023
Merged

FOUR-11744 / FOUR-11895 / FOUR-12198 #1488

merged 16 commits into from
Dec 11, 2023

Conversation

pmoskrojas
Copy link
Contributor

@pmoskrojas pmoskrojas commented Nov 22, 2023

Issue & Reproduction Steps

Expected behavior: FOUR-11744 / FOUR-11895 / FOUR-12198 are implemented
New design for Search Bar inside Control Menu and order for items
Actual behavior:

Solution

How to Test

Test the steps above

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.
    .

Copy link

cypress bot commented Nov 22, 2023

6 failed tests on run #173 ↗︎

6 263 12 0 Flakiness 0

Details:

Merge 150d754 into 5221d9f...
Project: screen-builder Commit: 363c663cc7 ℹ️
Status: Failed Duration: 07:26 💡
Started: Dec 8, 2023 1:14 PM Ended: Dec 8, 2023 1:22 PM
Failed  WrongConfigurationErrors.js • 1 failed test

View Output

Test Artifacts
Wrong Configuration Errors > Screen with rendering problem in a component should not show a warning after the problematic component is deleted Screenshots
Failed  FileUpload.spec.js • 1 failed test

View Output

Test Artifacts
File Upload > Disables when task is self service Screenshots
Failed  ComputedDateTime.spec.js • 1 failed test

View Output

Test Artifacts
Computed datetime > Screenshots
Failed  FOUR-7587_LoopNestedLoop.spec.js • 1 failed test

View Output

Test Artifacts
FOUR-7587 Loop Nested Loop > Test render of screen with Loop>Nested>Loop Screenshots
Failed  LoopFileUpload.spec.js • 1 failed test

View Output

Test Artifacts
FOUR-2164 Loop FileUpload > Test render of screen with Loop>FileUpload Screenshots

The first 5 failed specs are shown, see all 6 specs in Cypress Cloud.

Review all test suite changes for PR #1488 ↗︎

@nolanpro nolanpro changed the base branch from develop to next November 22, 2023 17:45
@nolanpro nolanpro self-requested a review November 22, 2023 18:20
Copy link
Contributor

@nolanpro nolanpro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pmoskrojas could we fix this weird border around the icon
PRD:
image

This PR:
image

and can the icons and text grey to match the PRD? Check with Ale to get the actual color:
PRD:
image

This PR:
image

Did we loose the bootstrap components?
image

@pmoskrojas
Copy link
Contributor Author

The errors were fixed as mentioned by @nolanpro, on the latest PR.

@nolanpro nolanpro self-requested a review November 27, 2023 22:23
Copy link

@pmoskrojas pmoskrojas merged commit 1d7124c into next Dec 11, 2023
9 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants