Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FOUR-12206: Deleting a File in File Upload does not synchronize File Download #1486

Merged
merged 3 commits into from
Nov 17, 2023

Conversation

eiresendez
Copy link
Contributor

@eiresendez eiresendez commented Nov 17, 2023

Issue & Reproduction Steps

Expected behavior:

  • After any file deletion, download file needs to be synchronized.

Actual behavior:

  • After file deleting, download file is not synchronized.

Solution

  • It was necessary to set the filesInfo array as empty when no files are present. This same functionality is already implemented in the setFilesInfoFromCollectionValue method.
    • The additional changes are simply related to formatting applied by eslint.

How to Test

  • Please follow the reproduction steps.

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

Copy link

@ryancooley ryancooley changed the title FOUR-12206: Deleting a File in File Upload does not synchrinize File Download FOUR-12206: Deleting a File in File Upload does not synchronize File Download Nov 17, 2023
@ryancooley ryancooley merged commit a82bd74 into develop Nov 17, 2023
26 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants