Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validations rules do not work the first time before pressing the Submit button #1478

Merged
merged 3 commits into from
Nov 4, 2023

Conversation

marcoAntonioNina
Copy link
Contributor

@marcoAntonioNina marcoAntonioNina commented Nov 3, 2023

Issue & Reproduction Steps

Validations are only shown after submitting.

Expected behavior:

  • When the form opens, there is no validation.
  • All required fields should be marked with a red asterisk (*).
  • Fields designated as "Required If," which meet their specified conditions, should also be identified with an asterisk (*).
  • While filling out the form, if a required field is left blank when completing the form in order, the empty field should be highlighted in red.
  • An alert message should be displayed when the validation criteria are not met while filling a field.
  • The field should also highlight in red when the Submit Button is clicked, and the validation criteria are not met.
  • These rules apply to loops, nested screens, and multiple screens.

Actual behavior:
Validations are only shown after submitting.

Solution

  • validate fields that only have required and required if validations

How to Test

validate forms that have validations

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

ci:deploy

Copy link

@tokensPM
Copy link

tokensPM commented Nov 3, 2023

QA server was successfully deployed https://ci-b9198b1af7.eng.processmaker.net

@ryancooley ryancooley added hold and removed hold labels Nov 3, 2023
@ryancooley ryancooley merged commit 77d1bc4 into develop Nov 4, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants