Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FOUR-10311 Redirect automatically to Request if the request was already completed #1443

Merged
merged 3 commits into from
Oct 3, 2023
Merged

FOUR-10311 Redirect automatically to Request if the request was already completed #1443

merged 3 commits into from
Oct 3, 2023

Conversation

caleeli
Copy link
Contributor

@caleeli caleeli commented Sep 27, 2023 •
edited
Loading

Issue & Reproduction Steps

Redirect automatically to Request if the request was already completed

Expected behavior:

Actual behavior:

Solution

How to Test

Test the steps above

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

ci:next

@caleeli caleeli changed the base branch from develop to next October 2, 2023 18:46
@caleeli caleeli requested a review from julceslauhub October 2, 2023 18:46
@caleeli caleeli force-pushed the bugfix/FOUR-10311 branch from 1456386 to e7e1f9c Compare October 2, 2023 18:47
@caleeli caleeli marked this pull request as ready for review October 2, 2023 18:47
@processmaker-sonarqube
Copy link

processmaker-sonarqube bot commented Oct 2, 2023 •
edited
Loading

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

julceslauhub
julceslauhub approved these changes Oct 2, 2023
View reviewed changes
Copy link
Contributor

@julceslauhub julceslauhub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@ryancooley ryancooley merged commit e03adce into next Oct 3, 2023
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julceslauhub julceslauhub julceslauhub approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@caleeli @julceslauhub @ryancooley