Add validation in test showOnSubmit

ProcessMaker · Nov 3, 2023 · a9dd93e · a9dd93e
1 parent 8b77807
commit a9dd93e
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 3 deletions.
diff --git a/src/mixins/extensions/ValidationRules.js b/src/mixins/extensions/ValidationRules.js
@@ -54,7 +54,6 @@ export default {
       return check.str;
     },
     fieldValidationShow (element) {
-      console.log('fieldValidationShow', element.config.name, element.config, element.config.validation);
       let showError = true;
       if (element.config && element.config.validation) {
         const validationHidden = ['Required', 'Required if'];

diff --git a/tests/e2e/specs/ValidationShownOnSubmit.spec.js b/tests/e2e/specs/ValidationShownOnSubmit.spec.js
@@ -9,8 +9,14 @@ describe('Validation Rules', () => {
   it('Invalid default values', () => {
     cy.loadFromJson('validation_rules.json', 0);
     cy.get('[data-cy=mode-preview]').click();
-
-    cy.shouldNotHaveValidationErrors('screen-field-form_input_1');
+
+    cy.shouldHaveValidationErrors('screen-field-form_checkbox_1');
+    cy.shouldHaveValidationErrors('screen-field-form_input_1');
+    cy.shouldHaveValidationErrors('screen-field-form_input_2');
+    cy.shouldNotHaveValidationErrors('screen-field-form_input_3');
+    cy.shouldHaveValidationErrors('screen-field-form_input_4');
+    cy.shouldNotHaveValidationErrors('screen-field-form_input_5');
+    cy.shouldNotHaveValidationErrors('screen-field-form_input_6');
 
     cy.get('[data-cy=preview-content] .page button').click();
 
@@ -19,6 +25,13 @@ describe('Validation Rules', () => {
     cy.get('[data-cy=preview-content] [data-cy="screen-field-form_input_1"]')
       .clear()
       .type('on');
+
+    cy.shouldHaveValidationErrors('screen-field-form_checkbox_1');
     cy.shouldNotHaveValidationErrors('screen-field-form_input_1');
+    cy.shouldHaveValidationErrors('screen-field-form_input_2');
+    cy.shouldNotHaveValidationErrors('screen-field-form_input_3');
+    cy.shouldHaveValidationErrors('screen-field-form_input_4');
+    cy.shouldNotHaveValidationErrors('screen-field-form_input_5');
+    cy.shouldNotHaveValidationErrors('screen-field-form_input_6');
   });
 });