Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FOUR-21263 implement a general method to index cache keys #7836

Merged
merged 11 commits into from
Dec 19, 2024

Conversation

devmiguelangel
Copy link
Contributor

@devmiguelangel devmiguelangel commented Dec 17, 2024

Issue & Reproduction Steps

As a developer, I would like to have a method to index and find keys on the Cache implementation.

Solution

  • Add a new abstract class CacheManagerBase
  • Implement the getKeysByPattern method
  • Add a console command to clear settings cache

How to Test

Run php artisan test --filter='SettingCacheTest|CacheManagerBaseTest'

Related Tickets & Packages

FOUR-21263

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

@devmiguelangel devmiguelangel self-assigned this Dec 17, 2024
Copy link
Contributor

@caleeli caleeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review the comments

@devmiguelangel devmiguelangel force-pushed the FOUR-21263 branch 3 times, most recently from 7e611ea to 1b514b3 Compare December 18, 2024 21:55
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@caleeli caleeli merged commit fafc69e into epic/FOUR-20326 Dec 19, 2024
8 checks passed
caleeli added a commit that referenced this pull request Jan 3, 2025
FOUR-21263 implement a general method to index cache keys
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants