-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FOUR-21263 implement a general method to index cache keys #7836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caleeli
reviewed
Dec 17, 2024
caleeli
reviewed
Dec 17, 2024
caleeli
reviewed
Dec 17, 2024
caleeli
reviewed
Dec 17, 2024
caleeli
requested changes
Dec 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please review the comments
devmiguelangel
force-pushed
the
FOUR-21263
branch
from
December 18, 2024 03:40
c7127c6
to
5792fac
Compare
… CacheManagerBase
devmiguelangel
force-pushed
the
FOUR-21263
branch
from
December 18, 2024 04:35
5792fac
to
df09a43
Compare
devmiguelangel
force-pushed
the
FOUR-21263
branch
3 times, most recently
from
December 18, 2024 21:55
7e611ea
to
1b514b3
Compare
devmiguelangel
force-pushed
the
FOUR-21263
branch
from
December 18, 2024 23:24
1b514b3
to
5f4c607
Compare
Quality Gate passedIssues Measures |
caleeli
approved these changes
Dec 19, 2024
caleeli
added a commit
that referenced
this pull request
Jan 3, 2025
FOUR-21263 implement a general method to index cache keys
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue & Reproduction Steps
As a developer, I would like to have a method to index and find keys on the Cache implementation.
Solution
CacheManagerBase
getKeysByPattern
methodHow to Test
Run
php artisan test --filter='SettingCacheTest|CacheManagerBaseTest'
Related Tickets & Packages
FOUR-21263
Code Review Checklist