New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update readme and add namespace config #7833

Merged

nolanpro merged 3 commits into feature/FOUR-20257 from feature/FOUR-21074

Dec 18, 2024

Contributor

gproly commented Dec 17, 2024

Descripción

I already

Set the namespace in the config (needed by cloudops)
removed unused code
updated the readme
made grafana development docker compose anonymous (no username/password needed)

We need to

Add the logic to MetricService to support Metrics::counter and Metrics::guage (and histogram the same way)
Use the metric name (first argument) as the 2nd argument (description) if not provided
Use config('app.prometheus_namespace') to set the namespace
use the library’s getOrRegister*** methods
Remove any additional unused code

Related Tickets & Packages

https://processmaker.atlassian.net/browse/FOUR-21074

nolanpro and others added 2 commits

December 16, 2024 12:57


          Update readme and add namespace config

a63afa7


          FOUR-21074 Improvements for a better user experience.

91d8a85

gproly requested a review from nolanpro

December 17, 2024 23:17


          Update prometheus.yml

ddbd267

processmaker-sonarqube bot commented Dec 18, 2024

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube

nolanpro approved these changes

View reviewed changes

nolanpro merged commit f433669 into feature/FOUR-20257

5 checks passed

nolanpro deleted the feature/FOUR-21074 branch

December 18, 2024 00:50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet