FOUR-20583: Improve vendors, boostrap and app-layout

[henryjonathanquispe]

Solution

• Create chunks for vendor.js in webpack.js

Related Tickets & Packages

• https://processmaker.atlassian.net/browse/FOUR-20584
• https://processmaker.atlassian.net/browse/FOUR-20583

Code Review Checklist

• I have pulled this code locally and tested it on my instance, along with any associated packages.
• This code adheres to ProcessMaker Coding Guidelines.
• This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
• This solution fixes the bug reported in the original ticket.
• This solution does not alter the expected output of a component in a way that would break existing Processes.
• This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
• This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
• This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
• This ticket conforms to the PRD associated with this part of ProcessMaker.

[nolanpro]

@pmPaulis @henryjonathanquispe Here are my initial notes and questions:

• loader*.js files have a lot of duplication. You could extract to a common folder and wrap the differences in if statements and call it like this

import { initializeCommonLoader } from "../next/commonLoader";
import sharedComponents from "../next/libraries/sharedComponents";
import vueFormElements from "../next/libraries/vueFormElements";

initializeCommonLoader({
 includeScreenBuilder: true,
 includeModeler: false,
 includeMonaco: false,
});

• is accesibility.js being used anywhere?
• If we make any changes to the logic in bootstrap.js and app-layout.js, do we need to duplicate that logic in the next folder until the entire app is converted to use the new code?
• What’s the purpose of the badPractices.js file?
• EventBus, apilient, etc. should be in their own files that are imported as a modules instead of being passed in with globalInput in next/config/*.js files. Can we get rid of globalInput attribute everywhere? If you really need a global import and use the globalVariables.js helper.

[processmaker-sonarqube]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube