Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow disabling task drafts with env var setting #6820

Merged
merged 4 commits into from
May 4, 2024
Merged

Conversation

nolanpro
Copy link
Contributor

@nolanpro nolanpro commented May 3, 2024

Issue & Reproduction Steps

We anticipate some clients will not want to use the task drafts feature

Solution

  • Allow disabling drafts by setting TASK_DRAFTS_ENABLED to false

How to Test

This CI instance has drafts disabled. Ensure drafts are not being saved or loaded

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

ci:next
ci:TASK_DRAFTS_ENABLED=false

@nolanpro nolanpro requested a review from gustavobascope May 3, 2024 17:52
Copy link
Contributor

@gustavobascope gustavobascope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved
The task list didn't dissapear after quick fill when the results are empty. I made the comparison between next-qa and the new branch
Screencast from 03-05-24 15:19:33.webm
The autosave options doesn't appear when the env var is false
image
image

@ryancooley ryancooley added the hold Issue is blocked or put on hold label May 3, 2024
Copy link

@ryancooley ryancooley removed the hold Issue is blocked or put on hold label May 4, 2024
@ryancooley ryancooley merged commit 806a4ee into next May 4, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants