Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FOUR-10833: Update warning messages for file upload(s) #5414

Merged
merged 3 commits into from
Oct 4, 2023

Conversation

runyan-co
Copy link
Contributor

@runyan-co runyan-co commented Oct 4, 2023

Issue

The primary issue is when a request participant attempts to upload a file of a type not allowed in a form upload field where it is not allowed. The previous warning was "File not allowed." and has been updated to "This file type is not accepted.".

Additionally, for the webentry warning message, the class of the notification (eg. "info", "danger") was being concatenated and used as a prefix for the warning message, changing it to "danger: File not allowed". The concatenation has been removed and only the update warning message ("This file type is not accepted.") should appear.

Requirements

Use this branch for core and the feature/FOUR-10833 branch for screen-builder.

Issue Reproduction Steps

  1. Import the attached process
  2. Copy the webentry link and attempt to upload a file which is not a JPEG or PNG file
  3. The window alert will show "danger: File not allowed."
  4. In the dashboard, start a new request with the process
  5. Repeat the file upload process (uploading a file which is not a JPEG or PNG)
  6. The notification will show "File not allowed."

Solution

  • Remove message concatenation for the window alert (specific to webentry screens)
  • Updated the "File not allowed." in two places, one in core and one in screen-builder

How to Test

  1. Import the attached process or use the previously imported process (which is the same one)
  2. Copy the webentry link and attempt to upload a file which is not a JPEG or PNG file
  3. The window alert should only show "This file type is not accepted."
  4. In the dashboard, start a new request with the process
  5. Repeat the file upload process (uploading a file which is not a JPEG or PNG)
  6. The notification should only show "This file type is not accepted."

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

@processmaker-sonarqube
Copy link

@ryancooley ryancooley merged commit 838d0ca into develop Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants