Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FOUR-12383 Update Template Elements #17

Merged
merged 36 commits into from
Dec 12, 2023
Merged

FOUR-12383 Update Template Elements #17

merged 36 commits into from
Dec 12, 2023

Conversation

estebangallego
Copy link
Contributor

@estebangallego estebangallego commented Nov 21, 2023

Description:

This pull request addresses the Ticket for Updating new template files.

Changes Made:

Revert uuid in some of the updated templates to prevent duplication
Add or update version to some of the templates in the manifest files
Update missing key to "default_templates" in some of the manifest files
Update user_id to null in some of the manifest files

How to test

  1. Delete all templates from the database.
  2. Update your .env to fetch the develop branch of the templates repo first.
DEFAULT_TEMPLATE_REPO=process-templates
DEFAULT_TEMPLATE_BRANCH=develop
DEFAULT_TEMPLATE_CATEGORIES=all

sync the templates php artisan processmaker:sync-default-templates
3. Check if the current templates are synced.
4. Update your .env to fetch the new templates from this branch DEFAULT_TEMPLATE_BRANCH=FOUR-12383

DEFAULT_TEMPLATE_REPO=process-templates
DEFAULT_TEMPLATE_BRANCH=FOUR-12383
DEFAULT_TEMPLATE_CATEGORIES=all

sync the templates php artisan processmaker:sync-default-templates
5. Please ensure that the new templates have been added and no duplicates have been included.
-- eg: Expense Approval 2

Ticket FOUR-12383

New templates added

Total amount 61 templates
Updated Residential Loan | Auto Loan request with latest UI and succesful export.
Added a functional project kickoff process.
Auto loan request template update, eliminated de SAAB label
All processes should have headers updated, banking elements were worked by manuel atm
Added category to missing templates
-Residential Loan
-Auto Loan request

Updated AI and mobile elements added
Added
Payment Request
Financial Application
Employee separation process
infosec risk
cash voucher
csat survey
long term leave
Copy link

@eiresendez eiresendez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First, 41 templates were synchronized. Then, with the second execution, 70 templates appeared. I don't see any repeated templates or issues 👍

@ryancooley ryancooley changed the base branch from develop to 2023-summer December 4, 2023 22:12
Copy link

gitguardian bot commented Dec 4, 2023

⚠️ GitGuardian has uncovered 19 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
- Generic High Entropy Secret 6c61c48 accounting-and-finance/invoice-approval.json View secret
- Generic High Entropy Secret 81b6fad accounting-and-finance/invoice-approval.json View secret
- Generic High Entropy Secret 6c61c48 operations/committee-approval.json View secret
- Generic High Entropy Secret a26597d accounting-and-finance/invoice-approval.json View secret
- Generic High Entropy Secret a26597d operations/committee-approval.json View secret
- Generic High Entropy Secret 81b6fad operations/committee-approval.json View secret
- Generic High Entropy Secret 81b6fad it/change-request.json View secret
- Generic High Entropy Secret 360d094 higher-education/disability-accomodation.json View secret
- Generic High Entropy Secret 6c61c48 operations/work-order-request.json View secret
- Generic High Entropy Secret 81b6fad human-resources/performance-review.json View secret
- Generic High Entropy Secret 6c61c48 it/change-request.json View secret
- Generic High Entropy Secret a26597d it/change-request.json View secret
- Generic High Entropy Secret fba6668 operations/work-order-request.json View secret
- Generic High Entropy Secret 3993c73 higher-education/disability-accomodation.json View secret
- Generic High Entropy Secret fba6668 higher-education/disability-accomodation.json View secret
- Generic High Entropy Secret 7a14c3b operations/work-order-request.json View secret
- Generic High Entropy Secret 6c61c48 higher-education/disability-accomodation.json View secret
- Generic High Entropy Secret 6c61c48 human-resources/performance-review.json View secret
- Generic High Entropy Secret a26597d higher-education/disability-accomodation.json View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@ryancooley ryancooley changed the base branch from 2023-summer to 2023-fall December 4, 2023 22:17
@ryancooley ryancooley merged commit 47a1183 into 2023-fall Dec 12, 2023
1 check failed
@ryancooley ryancooley deleted the FOUR-12383 branch December 12, 2023 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants