Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to connect to any mysql or redis database #8

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

rmetcalf9
Copy link

Issue & Reproduction Steps

I was not able to use this image to connect to my own mysql database server

Expected behaviour:
I wanted variables I could set in the env file to specify the mysql host, port, database, username and password.

Actual behaviour:
It is all hard coded in the init script

Solution

  • I have added the variables to the env script and made the init script use them
  • I have added instructions on how to setup the database
  • I also made it possible to reconfigure the redis host used

How to Test

Build the container and try with different database

Related Tickets & Packages

None

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • [N/A] This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • [N/A] This solution fixes the bug reported in the original ticket.
  • [ x] This solution does not alter the expected output of a component in a way that would break existing Processes.
  • [x[ This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • [N.A] This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • [huh???] This ticket conforms to the PRD associated with this part of ProcessMaker.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant